RE: Broken "Rating" button
01-23-2020, 11:13 PM (This post was last modified: 01-23-2020, 11:42 PM by Labster.)
01-23-2020, 11:13 PM (This post was last modified: 01-23-2020, 11:42 PM by Labster.)
OK, had to switch themes to rate a post. The only one that works it the MyBB default. But it looks like it's trying to work, right?
It sends a request to: http://www.accessdenied-rms.net/forums/r...33&modal=1 and that gets back a valid response! But what happens instead is that no Rate modal actually pops up, and I can no longer scroll the page. So obviously something modalish is happening, but I can't interact with it. Okay.
Let's investigate the page JS. Looks like it calls reputation which calls popupWindow. Right, this all looks like perfectly cromulent jQuery. http://www.accessdenied-rms.net/forums/j...s?ver=1810
OK, inspected the page elements. Aha, it actually appends the modal to the document. Good! But I'm not seeing it... Toggling some CSS, turning off overflow: none. Hey, there it is, at the end of the page! Our reputation box. But it doesn't have a close box. Where is that? Ah, here it is, halfway off the screen at the very top of the page, awesome. Not working; not awesome.
So lets compare how it renders between the default and SanFelix theme. OK, it looks like there's a CSS class ".blocker" so let's copy-paste that over... Oh, hey, looks modalish! Let's try clicking that big, beautiful close button.
> too much recursion
What?
OK, let's checkout the JS failure then... it's calling oldCloseFunction. And above that we have a comment: /* add keepelement to jquery-modal plugin */
Now we're getting somewhere!
Let's look it up, and then look in the page... yep, that's the same CSS for .blocker I just saw. Cool! So all of the other themes are just not loading a plugin: https://jquerymodal.com
Actually, looking at the theme, it looks like the CSS classes are there. https://github.com/vintagedaddyo/MyBB_Th....xml#L1753 Can you try updating the theme?
It sends a request to: http://www.accessdenied-rms.net/forums/r...33&modal=1 and that gets back a valid response! But what happens instead is that no Rate modal actually pops up, and I can no longer scroll the page. So obviously something modalish is happening, but I can't interact with it. Okay.
Let's investigate the page JS. Looks like it calls reputation which calls popupWindow. Right, this all looks like perfectly cromulent jQuery. http://www.accessdenied-rms.net/forums/j...s?ver=1810
OK, inspected the page elements. Aha, it actually appends the modal to the document. Good! But I'm not seeing it... Toggling some CSS, turning off overflow: none. Hey, there it is, at the end of the page! Our reputation box. But it doesn't have a close box. Where is that? Ah, here it is, halfway off the screen at the very top of the page, awesome. Not working; not awesome.
So lets compare how it renders between the default and SanFelix theme. OK, it looks like there's a CSS class ".blocker" so let's copy-paste that over... Oh, hey, looks modalish! Let's try clicking that big, beautiful close button.
> too much recursion
What?
OK, let's checkout the JS failure then... it's calling oldCloseFunction. And above that we have a comment: /* add keepelement to jquery-modal plugin */
Now we're getting somewhere!
Let's look it up, and then look in the page... yep, that's the same CSS for .blocker I just saw. Cool! So all of the other themes are just not loading a plugin: https://jquerymodal.com
Actually, looking at the theme, it looks like the CSS classes are there. https://github.com/vintagedaddyo/MyBB_Th....xml#L1753 Can you try updating the theme?
"Kitto daijoubu da yo." - Sakura Kinomoto